Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notice to old system integrations page #5097

Merged
merged 3 commits into from
Jul 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ The types of changes are:
### Changed
- Moving Privacy Center endpoint logging behind debug flag [#5103](https://github.com/ethyca/fides/pull/5103)
- Serve GVL languages as they are requested [#5112](https://github.com/ethyca/fides/pull/5112)
- Changed text on system integrations tab to direct to new integration management [#5097](https://github.com/ethyca/fides/pull/5097)

### Developer Experience
- Add `.syncignore` to reduce file sync size with new volumes [#5104](https://github.com/ethyca/fides/pull/5104)
Expand Down
24 changes: 19 additions & 5 deletions clients/admin-ui/src/features/system/hooks/useSystemFormTabs.tsx
Original file line number Diff line number Diff line change
@@ -1,17 +1,18 @@
import { DataFlowAccordion } from "common/system-data-flow/DataFlowAccordion";
import { Box, Text, useToast } from "fidesui";
import { Box, Link, Text, useToast } from "fidesui";
import NextLink from "next/link";
import { useRouter } from "next/router";
import { useCallback, useEffect, useState } from "react";

import { useAppDispatch, useAppSelector } from "~/app/hooks";
import { type TabData } from "~/features/common/DataTabs";
import { useFeatures } from "~/features/common/features";
import { useFeatures, useFlags } from "~/features/common/features";
import {
DirtyFormConfirmationModal,
useIsAnyFormDirty,
} from "~/features/common/hooks/useIsAnyFormDirty";
import { useSystemOrDatamapRoute } from "~/features/common/hooks/useSystemOrDatamapRoute";
import { INTEGRATION_MANAGEMENT_ROUTE } from "~/features/common/nav/v2/routes";
import { DEFAULT_TOAST_PARAMS } from "~/features/common/toast";
import ToastLink from "~/features/common/ToastLink";
import ConnectionForm from "~/features/datastore-connections/system_portal_config/ConnectionForm";
Expand Down Expand Up @@ -70,6 +71,9 @@ const useSystemFormTabs = ({
const [systemProcessesPersonalData, setSystemProcessesPersonalData] =
useState<boolean | undefined>(undefined);
const { plus: isPlusEnabled } = useFeatures();
const {
flags: { dataDiscoveryAndDetection },
} = useFlags();

// Once we have saved the system basics, subscribe to the query so that activeSystem
// stays up to date when redux invalidates the cache (for example, when we patch a connection config)
Expand Down Expand Up @@ -219,9 +223,19 @@ const useSystemFormTabs = ({
content: activeSystem ? (
<Box width={{ base: "100%", lg: "70%" }}>
<Box px={6} paddingBottom={2}>
<Text fontSize="sm" lineHeight={5} fontWeight="medium">
Integrations are used to process privacy requests for access,
erasure, portability, rectification, and consent.
<Text fontSize="sm" lineHeight={5}>
{dataDiscoveryAndDetection ? (
<>
Add an integration to start managing privacy requests and
consent. Visit{" "}
<Link href={INTEGRATION_MANAGEMENT_ROUTE} color="purple.500">
Integration Management
</Link>{" "}
to set up monitoring on databases.
</>
) : (
"Integrations are used to process privacy requests for access erasure, portability, rectification, and consent."
)}
</Text>
</Box>
<ConnectionForm
Expand Down
Loading