Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to support bidirectional consent #5118

Merged
merged 17 commits into from
Jul 31, 2024

Merge branch 'main' into PROD-2343-changes-to-support-bidirectional-c…

e23a7cc
Select commit
Loading
Failed to load commit list.
Merged

Changes to support bidirectional consent #5118

Merge branch 'main' into PROD-2343-changes-to-support-bidirectional-c…
e23a7cc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 28, 2024 in 0s

86.55% (target 85.00%)

View this Pull Request on Codecov

86.55% (target 85.00%)

Details

Codecov Report

Attention: Patch coverage is 82.19178% with 26 lines in your changes missing coverage. Please review.

Project coverage is 86.55%. Comparing base (7259f7d) to head (e23a7cc).

Files Patch % Lines
...vice/saas_request/saas_request_override_factory.py 52.63% 6 Missing and 3 partials ⚠️
src/fides/api/service/connectors/saas_connector.py 42.85% 5 Missing and 3 partials ⚠️
src/fides/api/schemas/consentable_item.py 86.84% 3 Missing and 2 partials ⚠️
src/fides/api/models/consent_automation.py 94.36% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5118      +/-   ##
==========================================
- Coverage   86.56%   86.55%   -0.02%     
==========================================
  Files         357      359       +2     
  Lines       22349    22479     +130     
  Branches     2954     2975      +21     
==========================================
+ Hits        19347    19457     +110     
- Misses       2480     2491      +11     
- Partials      522      531       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov