Fides Experience form fixes #5123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #9087 ↗︎
Details:
Review all test suite changes for PR #5123 ↗︎ |
||||||||||||||||||||
gilluminate
force-pushed
the
gill/PROD-2008_allow-users-to-dismiss-and
branch
from
87ed269 to
966b667
Compare
Kelsey-Ethyca
approved these changes
Jul 22, 2024
|
UAT ✅ Screen.Recording.2024-07-22.at.4.37.59.PM.mov |
Passing run #9090 ↗︎
Details:
Review all test suite changes for PR #5123 ↗︎ |
||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PROD-2008
Description Of Changes
Backend defaults weren't reflected in the Frontend. These fields weren't being passed at all if not set, which caused the backend to apply its defaults. Since backend defaults are set to "true" on both of these fields, it was a mismatched experience.
Setting these to default to "true" on the Frontend now to match BE defaults. User can turn them off without issue during initial save.
Code Changes
Steps to Confirm
observe that the "allow users to dismiss" and "auto detect language" are in the correct state. Repeating the steps above and opting to turn off those 2 should reflect them as off here as well.
Pre-Merge Checklist
CHANGELOG.md