PROD-1782: Allows approver to view user management table so they can reset their own password #5178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
eastandwestwind
force-pushed
the
PROD-1782
branch
from
170c782 to
9cfd4ef
Compare
eastandwestwind
changed the title
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5178 +/- ##
=======================================
Coverage 86.48% 86.48%
=======================================
Files 360 360
Lines 22521 22521
Branches 2981 2981
=======================================
Hits 19477 19477
Misses 2511 2511
Partials 533 533 ☔ View full report in Codecov by Sentry. |
lucanovera
approved these changes
Aug 12, 2024
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://ethyca.atlassian.net/browse/PROD-1782
Description Of Changes
Adds a scope to the approver role so that they can view the user management section of the Admin-UI. We already have appropriate checks in place so that the approver cannot delete other users or change other users' info.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdmaindowngrade()migration is correct and works