Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing downgrade for OpenID provider migration #5205

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Aug 15, 2024

Closes PROD-2618

Description Of Changes

The current downgrade step of the OpenID provider migration does not drop the providertype enum.

Code Changes

  • Fixed migration

Steps to Confirm

  • Downgrade to the revision before this one d69cf8f82a58
  • Run alembic upgrade head, the command should be successful

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met

Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Aug 15, 2024 9:24pm

Copy link
Contributor

@pattisdr pattisdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great 👍

Copy link

cypress bot commented Aug 15, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 659a07496e ℹ️
Started Aug 15, 2024 9:37 PM
Ended Aug 15, 2024 9:38 PM
Duration 00:38 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@galvana galvana merged commit d739aad into main Aug 15, 2024
43 checks passed
@galvana galvana deleted the PROD-2618-fix-migration branch August 15, 2024 21:38
Copy link

cypress bot commented Aug 15, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit d739aad
Started Aug 15, 2024 9:50 PM
Ended Aug 15, 2024 9:51 PM
Duration 00:36 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.56%. Comparing base (07b3289) to head (f57e9ab).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5205   +/-   ##
=======================================
  Coverage   86.56%   86.56%           
=======================================
  Files         362      362           
  Lines       22741    22741           
  Branches     3026     3026           
=======================================
  Hits        19685    19685           
  Misses       2511     2511           
  Partials      545      545           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants