-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HJ-32 Add endpoint to get privacy request access results urls #5379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
erosselli
changed the title
HJ-32 Add endpoint to download privacy request access results
HJ-32 Add endpoint to get privacy request access results urls
Oct 15, 2024
fides Run #10462
Run Properties:
|
Project |
fides
|
Run status |
Passed #10462
|
Run duration | 00m 36s |
Commit |
50c6891dc1 ℹ️: Merge 04d7371ffa2af167c82302351812f9f4171f0f40 into e55d71f66ed37d3980ff370ca908...
|
Committer | erosselli |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Upgrade your plan to view test results. |
andres-torres-marroquin
requested changes
Oct 15, 2024
andres-torres-marroquin
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HJ-32
Description Of Changes
Adds a new endpoint that allows getting a privacy request's access results URLs.
Code Changes
GET /privacy-request/<privacy_request_id>/access-results
PRIVACY_REQUEST_GET_ACCESS_RESULTS
, only for owner and contributor rolesSteps to Confirm
nox -s dev
) as well as both the Admin UI and the Privacy CenterComplete
in the Admin UI/api/v1/privacy-request/{privacy_request_id}/access-results
:"access_result_urls": ["your local fides_uploads folder"]
Pre-Merge Checklist
CHANGELOG.md
main
downgrade()
migration is correct and works