Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HJ-56 - Add RDS Postgres to ConnectorType #5382

Merged
merged 3 commits into from
Oct 15, 2024
Merged

HJ-56 - Add RDS Postgres to ConnectorType #5382

merged 3 commits into from
Oct 15, 2024

Conversation

andres-torres-marroquin
Copy link
Contributor

Description Of Changes

Some groundwork for HJ-5

Code Changes

  • Added a migration for adding RDS Postgres to ConnectorType

Steps to Confirm

  • Run the migration
  • Confirm that the new type includes rds_postgres

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@vercel Vercel
Copy link

vercel bot commented Oct 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 3:59pm

@andres-torres-marroquin andres-torres-marroquin mentioned this pull request Oct 15, 2024
Closed
14 tasks
@cypress Cypress
Copy link

cypress bot commented Oct 15, 2024 •
edited
Loading

fides    Run #10434

Run Properties:  status check passed Passed #10434  •  git commit a793f12255 ℹ️: Merge dc790a7549d6c0aacdb2159b114c560ca2e662ae into 8174a84d36239402fbf20651c9a4...
Project fides
Run status status check passed Passed #10434
Run duration 00m 39s
Commit git commit a793f12255 ℹ️: Merge dc790a7549d6c0aacdb2159b114c560ca2e662ae into 8174a84d36239402fbf20651c9a4...
Committer Andres Torres
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

@andres-torres-marroquin andres-torres-marroquin mentioned this pull request Oct 15, 2024
Merged
17 tasks
erosselli
erosselli approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@erosselli erosselli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran locally and it worked

@andres-torres-marroquin andres-torres-marroquin merged commit 7038f61 into main Oct 15, 2024
37 checks passed
@andres-torres-marroquin andres-torres-marroquin deleted the andres/HJ-56 branch October 15, 2024 17:38
@cypress Cypress
Copy link

cypress bot commented Oct 15, 2024

fides    Run #10442

Run Properties:  status check passed Passed #10442  •  git commit 7038f61492: HJ-56 - Add RDS Postgres to ConnectorType (#5382)
Project fides
Run status status check passed Passed #10442
Run duration 00m 39s
Commit git commit 7038f61492: HJ-56 - Add RDS Postgres to ConnectorType (#5382)
Committer Andres Torres
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Kelsey-Ethyca pushed a commit that referenced this pull request Oct 17, 2024
@andres-torres-marroquin @Kelsey-Ethyca
HJ-56 - Add RDS Postgres to ConnectorType (#5382)
2c6c1f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erosselli erosselli erosselli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andres-torres-marroquin @erosselli