-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIDES-1412: Update integration guides to not 404 #5394
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides Run #10502
Run Properties:
|
Project |
fides
|
Run status |
Passed #10502
|
Run duration | 00m 38s |
Commit |
5e22c19033 ℹ️: Merge da2a3791cf69426c75bc370625af67651039bb49 into 60f69d6c12c41cdab612c5d03e96...
|
Committer | Tom Van Dort |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Upgrade your plan to view test results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5394 +/- ##
=======================================
Coverage 85.58% 85.58%
=======================================
Files 379 379
Lines 23984 23984
Branches 2623 2623
=======================================
Hits 20526 20526
Misses 2906 2906
Partials 552 552 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Also, we havent been using this field on recent integrations. Im thinking we should start setting it up again @Linker44 what do you think?
huh i didnt know this was a thing, we should absolutely start adding this. |
Thanks for that call out @Vagoasdf, I just went through all the integrations again and added user guide links to all of the integrations where there were none that we do have a docs page for. There are a few integrations without docs pages:
I might make a ticket to get those added in both places. |
fides Run #10505
Run Properties:
|
Project |
fides
|
Run status |
Passed #10505
|
Run duration | 00m 40s |
Commit |
cb0579859b: FIDES-1412: Update integration guides to not 404 (#5394)
|
Committer | Tom Van Dort |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Upgrade your plan to view test results. |
Closes FIDES-1412
Description Of Changes
Updates integration user guides to correct URLs instead of older URLs that 404.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
main
downgrade()
migration is correct and works