Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIDES-1412: Update integration guides to not 404 #5394

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

tvandort
Copy link
Contributor

@tvandort tvandort commented Oct 16, 2024

Closes FIDES-1412

Description Of Changes

Updates integration user guides to correct URLs instead of older URLs that 404.

Code Changes

  • Some integration URLs

Steps to Confirm

  • Click on the links in the yaml files.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@tvandort tvandort requested a review from a team as a code owner October 16, 2024 23:18
Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 1:56pm

Copy link

cypress bot commented Oct 16, 2024

fides    Run #10502

Run Properties:  status check passed Passed #10502  •  git commit 5e22c19033 ℹ️: Merge da2a3791cf69426c75bc370625af67651039bb49 into 60f69d6c12c41cdab612c5d03e96...
Project fides
Run status status check passed Passed #10502
Run duration 00m 38s
Commit git commit 5e22c19033 ℹ️: Merge da2a3791cf69426c75bc370625af67651039bb49 into 60f69d6c12c41cdab612c5d03e96...
Committer Tom Van Dort
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.58%. Comparing base (60f69d6) to head (da2a379).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5394   +/-   ##
=======================================
  Coverage   85.58%   85.58%           
=======================================
  Files         379      379           
  Lines       23984    23984           
  Branches     2623     2623           
=======================================
  Hits        20526    20526           
  Misses       2906     2906           
  Partials      552      552           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Vagoasdf Vagoasdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Also, we havent been using this field on recent integrations. Im thinking we should start setting it up again @Linker44 what do you think?

@Linker44
Copy link
Contributor

Nice catch! Also, we havent been using this field on recent integrations. Im thinking we should start setting it up again @Linker44 what do you think?

huh i didnt know this was a thing, we should absolutely start adding this.

@tvandort
Copy link
Contributor Author

tvandort commented Oct 17, 2024

Thanks for that call out @Vagoasdf, I just went through all the integrations again and added user guide links to all of the integrations where there were none that we do have a docs page for.

There are a few integrations without docs pages:

  • gladly
  • shipstation

I might make a ticket to get those added in both places.

@tvandort tvandort merged commit cb05798 into main Oct 17, 2024
39 checks passed
@tvandort tvandort deleted the FIDES-1412-fix-user-guide-links branch October 17, 2024 14:39
Copy link

cypress bot commented Oct 17, 2024

fides    Run #10505

Run Properties:  status check passed Passed #10505  •  git commit cb0579859b: FIDES-1412: Update integration guides to not 404 (#5394)
Project fides
Run status status check passed Passed #10505
Run duration 00m 40s
Commit git commit cb0579859b: FIDES-1412: Update integration guides to not 404 (#5394)
Committer Tom Van Dort
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants