-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use NextJS catch-all segments instead of URN #5396
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides Run #10508
Run Properties:
|
Project |
fides
|
Run status |
Passed #10508
|
Run duration | 00m 37s |
Commit |
7147d0497d ℹ️: Merge 552ad78436d973cf2357a4f688a917ee95815e44 into cb0579859b31e8f3b8c8ef5c232f...
|
Committer | Jason Gill |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Upgrade your plan to view test results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 💯 . This is a better pattern, it's great that is more robust in handling weird characters and simpler because of the delegation of parsing the url to next.js. I tested this and other datasets without any problems.
fides Run #10513
Run Properties:
|
Project |
fides
|
Run status |
Passed #10513
|
Run duration | 00m 39s |
Commit |
fa1b922c52: Use NextJS catch-all segments instead of URN (#5396)
|
Committer | Jason Gill |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Upgrade your plan to view test results. |
Closes #
Description Of Changes
Utilize NextJS catch-all segments to avoid the need for "." separated
subfieldURN
and encode/decode all field names when used as URL parts.(see https://nextjs.org/docs/pages/building-your-application/routing/dynamic-routes#catch-all-segments)
Code Changes
Steps to Confirm
example_dataset_issue_hj36
table as long as there are subfields availablePre-Merge Checklist
CHANGELOG.md