Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HJ-7 - Add MicrosoftSQLServerMonitor support code #5404

Merged
merged 8 commits into from
Oct 24, 2024
Merged

HJ-7 - Add MicrosoftSQLServerMonitor support code #5404

merged 8 commits into from
Oct 24, 2024

Conversation

andres-torres-marroquin
Copy link
Contributor

@andres-torres-marroquin andres-torres-marroquin commented Oct 22, 2024 •
edited
Loading

Closes #HJ-7

Description Of Changes

HJ-7 - Add MicrosoftSQLServerMonitor support code

Code Changes

  • Make MicrosoftSQLServerSchema.dbname optional
  • Add Integrations UI for MicrosoftSQLServerMonitor

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@vercel Vercel
Copy link

vercel bot commented Oct 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly 🛑 Canceled (Inspect) Oct 24, 2024 5:42pm

@cypress Cypress
Copy link

cypress bot commented Oct 22, 2024 •
edited
Loading

fides    Run #10624

Run Properties:  status check passed Passed #10624  •  git commit 10704ce3c2 ℹ️: Merge f9fd54f5267a9deb8f419c46c58efb1e0f3f812d into 04a08730fc4a95fc535cacc0a035...
Project fides
Branch Review refs/pull/5404/merge
Run status status check passed Passed #10624
Run duration 00m 38s
Commit git commit 10704ce3c2 ℹ️: Merge f9fd54f5267a9deb8f419c46c58efb1e0f3f812d into 04a08730fc4a95fc535cacc0a035...
Committer Andres Torres
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@codecov Codecov
Copy link

codecov bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.88%. Comparing base (04a0873) to head (f9fd54f).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5404      +/-   ##
==========================================
- Coverage   83.89%   83.88%   -0.01%     
==========================================
  Files         384      384              
  Lines       24112    24112              
  Branches     2624     2624              
==========================================
- Hits        20228    20227       -1     
  Misses       3302     3302              
- Partials      582      583       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andres-torres-marroquin andres-torres-marroquin marked this pull request as ready for review October 22, 2024 23:44
thingscouldbeworse
thingscouldbeworse reviewed Oct 24, 2024
View reviewed changes
Copy link
Contributor

@thingscouldbeworse thingscouldbeworse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~

clients/admin-ui/src/features/integrations/add-integration/allIntegrationTypes.tsx Outdated Show resolved Hide resolved
clients/admin-ui/src/types/api/index.ts Outdated Show resolved Hide resolved
tests/ops/api/v1/endpoints/test_connection_template_endpoints.py Show resolved Hide resolved
@andres-torres-marroquin andres-torres-marroquin merged commit f4288b4 into main Oct 24, 2024
44 of 45 checks passed
@andres-torres-marroquin andres-torres-marroquin deleted the andres/HJ-7 branch October 24, 2024 18:18
@cypress Cypress
Copy link

cypress bot commented Oct 24, 2024

fides    Run #10627

Run Properties:  status check passed Passed #10627  •  git commit f4288b4ad9: HJ-7 - Add MicrosoftSQLServerMonitor support code (#5404)
Project fides
Branch Review main
Run status status check passed Passed #10627
Run duration 00m 38s
Commit git commit f4288b4ad9: HJ-7 - Add MicrosoftSQLServerMonitor support code (#5404)
Committer Andres Torres
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thingscouldbeworse thingscouldbeworse thingscouldbeworse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andres-torres-marroquin @thingscouldbeworse