-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing external SaaS tests #5463
Fixing external SaaS tests #5463
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fides Run #10815
Run Properties:
|
Project |
fides
|
Branch Review |
refs/pull/5463/merge
|
Run status |
Passed #10815
|
Run duration | 00m 36s |
Commit |
1f125a0592 ℹ️: Merge 3843cc3e255bf9fbe02f18688ea0a05bebb67044 into c11da91030fa3d057c1706d14ea7...
|
Committer | Adrian Galvan |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
View all changes introduced in this branch ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5463 +/- ##
=======================================
Coverage 85.47% 85.48%
=======================================
Files 384 384
Lines 24119 24119
Branches 2625 2625
=======================================
+ Hits 20615 20617 +2
+ Misses 2950 2949 -1
+ Partials 554 553 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you for this!
fides Run #10838
Run Properties:
|
Project |
fides
|
Branch Review |
main
|
Run status |
Passed #10838
|
Run duration | 00m 38s |
Commit |
8efe758379: Fixing external SaaS tests (#5463)
|
Committer | Adrian Galvan |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
View all changes introduced in this branch ↗︎ |
Closes #LA-94
Description Of Changes
Updating the external SaaS tests to work without the integration definitions that we moved to Fidesplus.
Code Changes
saas_example_config.yml
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md