Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing external SaaS tests #5463

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Nov 5, 2024

Closes #LA-94

Description Of Changes

Updating the external SaaS tests to work without the integration definitions that we moved to Fidesplus.

Code Changes

  • Updating some tests to use the saas_example_config.yml
  • Skipping other tests that we need to move to Fidesplus

Steps to Confirm

  • External SaaS tests should pass

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Update CHANGELOG.md

@galvana galvana requested a review from a team as a code owner November 5, 2024 20:12
Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 11:17pm

@galvana galvana added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Nov 5, 2024
Copy link

cypress bot commented Nov 5, 2024

fides    Run #10815

Run Properties:  status check passed Passed #10815  •  git commit 1f125a0592 ℹ️: Merge 3843cc3e255bf9fbe02f18688ea0a05bebb67044 into c11da91030fa3d057c1706d14ea7...
Project fides
Branch Review refs/pull/5463/merge
Run status status check passed Passed #10815
Run duration 00m 36s
Commit git commit 1f125a0592 ℹ️: Merge 3843cc3e255bf9fbe02f18688ea0a05bebb67044 into c11da91030fa3d057c1706d14ea7...
Committer Adrian Galvan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.48%. Comparing base (c11da91) to head (3843cc3).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5463   +/-   ##
=======================================
  Coverage   85.47%   85.48%           
=======================================
  Files         384      384           
  Lines       24119    24119           
  Branches     2625     2625           
=======================================
+ Hits        20615    20617    +2     
+ Misses       2950     2949    -1     
+ Partials      554      553    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andres-torres-marroquin andres-torres-marroquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for this!

@galvana galvana merged commit 8efe758 into main Nov 6, 2024
40 of 42 checks passed
@galvana galvana deleted the LA-94-fix-tests-on-fides-external-saas-connectors branch November 6, 2024 17:05
Copy link

cypress bot commented Nov 6, 2024

fides    Run #10838

Run Properties:  status check passed Passed #10838  •  git commit 8efe758379: Fixing external SaaS tests (#5463)
Project fides
Branch Review main
Run status status check passed Passed #10838
Run duration 00m 38s
Commit git commit 8efe758379: Fixing external SaaS tests (#5463)
Committer Adrian Galvan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants