Apply updated taxonomy labels and patterns to other columns in the data map report #5464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a system that populates each of the following columns in the Data map report * Data use * Data category * Data subjects * Data Stewards (can this even be done? * Destinations * Features * Sources * Legal Basis for profiling * Legal Basis for transfers * Responsibilities * Shared Categories * System Dependencies * System Undeclared data categories * Data use undeclared categories * Cookies Ensure all of those columns have the new, consistent looking badge.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gilluminate
changed the title
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5464/merge
|
| Run status |
|
| Run duration | 00m 39s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
| View all changes introduced in this branch ↗︎ | |
|
Mostly looks good to me-- small nitpick, but some longer badge contents are getting cut off at the default column width, which seems annoying if it's easy to fix. Not a huge deal if not though. |
@jpople good call. I added the |
jpople
approved these changes
Nov 5, 2024
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 36s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HJ-39
Description Of Changes
Any column in Data map report that uses a badge should have the newer badge look/feel
Code Changes
badgeProps={{ variant: "outline" }}to each column using theGroupCountBadgeCellcomponent as the cell rendererSteps to Confirm
Create a system that populates each of the following columns in the Data map report
Ensure all of those columns have the new, consistent looking badge.
Note: Data use and Data category columns already have this new look/feel, so you can reference those for consistency with the update to all of the other columns for this story.
Pre-Merge Checklist
CHANGELOG.md