Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source-destination save button #5469

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Nov 6, 2024

Closes HJ-164

Description Of Changes

Restores the HTML submit type to the "Save" button in the system detail source/destination forms so the form works again (it was accidentally removed in the Ant button migration).

Steps to Confirm

  • Add a source or destination to a system; on clicking "save" should be saved

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 3:46pm

Copy link

cypress bot commented Nov 6, 2024

fides    Run #10829

Run Properties:  status check passed Passed #10829  •  git commit 9b0cfa7ec3 ℹ️: Merge a4259b5c46cd5287e5d467886e31e503f97e5e68 into 5ca600a13c07e6b3ac1f0e0e88cd...
Project fides
Branch Review refs/pull/5469/merge
Run status status check passed Passed #10829
Run duration 00m 38s
Commit git commit 9b0cfa7ec3 ℹ️: Merge a4259b5c46cd5287e5d467886e31e503f97e5e68 into 5ca600a13c07e6b3ac1f0e0e88cd...
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

@jpople jpople merged commit 5389ae0 into main Nov 6, 2024
13 checks passed
@jpople jpople deleted the jpople/hj-164/fix-source-destination-save-button branch November 6, 2024 16:02
Copy link

cypress bot commented Nov 6, 2024

fides    Run #10834

Run Properties:  status check passed Passed #10834  •  git commit 5389ae0b25: Fix source-destination save button (#5469)
Project fides
Branch Review main
Run status status check passed Passed #10834
Run duration 00m 37s
Commit git commit 5389ae0b25: Fix source-destination save button (#5469)
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants