Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running static checks properly #5471

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

Vagoasdf
Copy link
Contributor

@Vagoasdf Vagoasdf commented Nov 6, 2024

Running Static Checks for PRs
5452
and 5429

Description Of Changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@Vagoasdf Vagoasdf requested a review from a team as a code owner November 6, 2024 18:42
Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Nov 6, 2024 6:42pm

@Vagoasdf Vagoasdf merged commit 20b3a9c into main Nov 6, 2024
17 checks passed
@Vagoasdf Vagoasdf deleted the fixing_failing_static_checks branch November 6, 2024 18:47
Copy link

cypress bot commented Nov 6, 2024

fides    Run #10848

Run Properties:  status check passed Passed #10848  •  git commit 4909f3aa2b ℹ️: Merge b8b2ea18dc77ec6ea9e5cfb221b9c88b9604a2d8 into 0e36182fd8337242ecf5b874ab95...
Project fides
Branch Review refs/pull/5471/merge
Run status status check passed Passed #10848
Run duration 00m 37s
Commit git commit 4909f3aa2b ℹ️: Merge b8b2ea18dc77ec6ea9e5cfb221b9c88b9604a2d8 into 0e36182fd8337242ecf5b874ab95...
Committer Bruno Gutierrez Rios
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Copy link

cypress bot commented Nov 6, 2024

fides    Run #10849

Run Properties:  status check passed Passed #10849  •  git commit 20b3a9c996: Running static checks properly (#5471)
Project fides
Branch Review main
Run status status check passed Passed #10849
Run duration 00m 38s
Commit git commit 20b3a9c996: Running static checks properly (#5471)
Committer Bruno Gutierrez Rios
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.30%. Comparing base (0e36182) to head (b8b2ea1).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...de_implementations/salesforce_request_overrides.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5471   +/-   ##
=======================================
  Coverage   85.30%   85.30%           
=======================================
  Files         386      386           
  Lines       24206    24206           
  Branches     2636     2636           
=======================================
  Hits        20649    20649           
  Misses       3004     3004           
  Partials      553      553           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants