-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running static checks properly #5471
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
galvana
approved these changes
Nov 6, 2024
fides Run #10848
Run Properties:
|
Project |
fides
|
Branch Review |
refs/pull/5471/merge
|
Run status |
Passed #10848
|
Run duration | 00m 37s |
Commit |
4909f3aa2b ℹ️: Merge b8b2ea18dc77ec6ea9e5cfb221b9c88b9604a2d8 into 0e36182fd8337242ecf5b874ab95...
|
Committer | Bruno Gutierrez Rios |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
View all changes introduced in this branch ↗︎ |
fides Run #10849
Run Properties:
|
Project |
fides
|
Branch Review |
main
|
Run status |
Passed #10849
|
Run duration | 00m 38s |
Commit |
20b3a9c996: Running static checks properly (#5471)
|
Committer | Bruno Gutierrez Rios |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
View all changes introduced in this branch ↗︎ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5471 +/- ##
=======================================
Coverage 85.30% 85.30%
=======================================
Files 386 386
Lines 24206 24206
Branches 2636 2636
=======================================
Hits 20649 20649
Misses 3004 3004
Partials 553 553 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running Static Checks for PRs
5452
and 5429
Description Of Changes
Pre-Merge Checklist
CHANGELOG.md
main
downgrade()
migration is correct and works