Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LA-128 Fix docs for region codes #5511

Merged
merged 1 commit into from
Nov 19, 2024
Merged

LA-128 Fix docs for region codes #5511

merged 1 commit into from
Nov 19, 2024

Conversation

lucanovera
Copy link
Contributor

Description of Changes

  • Update fides docs for region code to be enumerations
  • Wrote .ts file with special comments that autogenerates .md docs files

Pre-Merge Checklist

  • All CI Pipelines Succeeded

@vercel Vercel
Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Nov 18, 2024 8:30pm

@lucanovera lucanovera changed the title LAS-128 Fix docs for region codes LA-128 Fix docs for region codes Nov 18, 2024
@cypress Cypress
Copy link

cypress bot commented Nov 18, 2024

fides    Run #11052

Run Properties:  status check passed Passed #11052  •  git commit ad4bc1ec5a ℹ️: Merge cf8addba2f7cf720b3765e5a7e3e565fdb52ed6e into b8add27de81b9851e2957192f50c...
Project fides
Branch Review refs/pull/5511/merge
Run status status check passed Passed #11052
Run duration 00m 39s
Commit git commit ad4bc1ec5a ℹ️: Merge cf8addba2f7cf720b3765e5a7e3e565fdb52ed6e into b8add27de81b9851e2957192f50c...
Committer Lucano Vera
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@lucanovera lucanovera merged commit 6fc8086 into main Nov 19, 2024
13 checks passed
@lucanovera lucanovera deleted the LA-128-Fix-region-code-docs branch November 19, 2024 13:03
@cypress Cypress
Copy link

cypress bot commented Nov 19, 2024

fides    Run #11071

Run Properties:  status check passed Passed #11071  •  git commit 6fc80862e4: LA-128 Fix docs for region codes (#5511)
Project fides
Branch Review main
Run status status check passed Passed #11071
Run duration 00m 37s
Commit git commit 6fc80862e4: LA-128 Fix docs for region codes (#5511)
Committer Lucano Vera
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eastandwestwind eastandwestwind eastandwestwind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucanovera @eastandwestwind