Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating masking strict check to use config proxy #5512

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Updating masking strict check to use config proxy #5512

merged 3 commits into from
Nov 19, 2024

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Nov 19, 2024 •
edited
Loading

Description Of Changes

Updates the config lookup in SaaSQueryConfig.get_masking_request to use ConfigProxy. This was done so we can update the value of masking_strict from Fidesplus.

Steps to Confirm

  1. Tests should pass, functionality remains the same

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Nov 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 6:07pm

@galvana galvana requested a review from Linker44 November 19, 2024 04:02
@cypress Cypress
Copy link

cypress bot commented Nov 19, 2024 •
edited
Loading

fides    Run #11082

Run Properties:  status check passed Passed #11082  •  git commit 8fcfcfd279 ℹ️: Merge ed5378be985842e358968466a905666ba82fc7a2 into 8c59e5d3961d9e23206566f12192...
Project fides
Branch Review refs/pull/5512/merge
Run status status check passed Passed #11082
Run duration 00m 37s
Commit git commit 8fcfcfd279 ℹ️: Merge ed5378be985842e358968466a905666ba82fc7a2 into 8c59e5d3961d9e23206566f12192...
Committer Adrian Galvan
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@galvana galvana added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Nov 19, 2024
Linker44
Linker44 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@Linker44 Linker44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@galvana galvana merged commit 2321052 into main Nov 19, 2024
37 checks passed
@galvana galvana deleted the update-masking-strict-check-to-use-config-proxy branch November 19, 2024 20:27
@cypress Cypress
Copy link

cypress bot commented Nov 19, 2024

fides    Run #11091

Run Properties:  status check passed Passed #11091  •  git commit 2321052827: Updating masking strict check to use config proxy (#5512)
Project fides
Branch Review main
Run status status check passed Passed #11091
Run duration 00m 42s
Commit git commit 2321052827: Updating masking strict check to use config proxy (#5512)
Committer Adrian Galvan
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Linker44 Linker44 Linker44 approved these changes

Assignees
No one assigned
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galvana @Linker44