Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Andres/possible ctl not external test fix #5562

Closed
wants to merge 8 commits into from
Closed

Andres/possible ctl not external test fix #5562

wants to merge 8 commits into from

Conversation

andres-torres-marroquin
Copy link
Contributor

Closes #

Description Of Changes

Write some things here about the changes and any potential caveats

Code Changes

  • list your code changes here

Steps to Confirm

  1. list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Dec 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 2:13pm

@cypress Cypress
Copy link

cypress bot commented Dec 5, 2024 •
edited
Loading

fides    Run #11316

Run Properties:  status check passed Passed #11316  •  git commit 35d2d54144 ℹ️: Merge e0eca4d978301771473e270d95a38448bc62f452 into ca8e8470f38218fd95d448e1cf64...
Project fides
Branch Review refs/pull/5562/merge
Run status status check passed Passed #11316
Run duration 00m 51s
Commit git commit 35d2d54144 ℹ️: Merge e0eca4d978301771473e270d95a38448bc62f452 into ca8e8470f38218fd95d448e1cf64...
Committer Andres Torres
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

@andres-torres-marroquin andres-torres-marroquin added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Dec 5, 2024
@andres-torres-marroquin
Copy link
Contributor Author

andres-torres-marroquin commented Dec 6, 2024 •
edited
Loading

Superceded by #5568

@andres-torres-marroquin andres-torres-marroquin deleted the andres/possible-ctl-not-external-test-fix branch December 6, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andres-torres-marroquin