HJ-300 - Timed out tests should fail on CI #5571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
13 tasks
I think we we can keep some of the other ones in place, we currently have:
|
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5571/merge
|
| Run status |
|
| Run duration | 01m 06s |
| Commit |
|
| Committer | Andres Torres |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
| View all changes introduced in this branch ↗︎ | |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5571 +/- ##
=======================================
Coverage 79.02% 79.02%
=======================================
Files 389 389
Lines 24722 24722
Branches 2702 2702
=======================================
+ Hits 19536 19537 +1
Misses 4665 4665
+ Partials 521 520 -1 ☔ View full report in Codecov by Sentry. |
adamsachs
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
looks good, let's just keep our eyes out for two things related to this, moving forward:
- whether there are any unintended side effects of switching this off, i.e. maybe it was in place originally for a legitimate reason that we haven't considered. i think it should be fine, but just wanna state this so we can both keep our eyes out!
- whether it may make sense to switch this off for any of the other CI jobs it's currently enabled for. maybe it's fine to keep, per your comment - but let's just keep that possibility in the back of our minds!
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 38s |
| Commit |
|
| Committer | Andres Torres |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
andres-torres-marroquin
added a commit
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #HJ-300
Description Of Changes
Timed out tests should fail on CI, they are now actually failing on timeout.
Code Changes
continue-on-errorforSafe-TestsSteps to Confirm
continue-on-errorforSafe-TestsPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works