Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HJ-300 - Adds fail-fast: false to Safe-Tests build strategy #5586

Merged
merged 11 commits into from
Dec 10, 2024
Merged

HJ-300 - Adds fail-fast: false to Safe-Tests build strategy #5586

merged 11 commits into from
Dec 10, 2024

Conversation

andres-torres-marroquin
Copy link
Contributor

Closes #HJ-300

Description Of Changes

Adds fail-fast: false to Safe-Tests build strategy

Code Changes

Adds fail-fast: false to Safe-Tests build strategy to backend_checks.yml

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Dec 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 2:28pm

@cypress Cypress
Copy link

cypress bot commented Dec 10, 2024 •
edited
Loading

fides    Run #11395

Run Properties:  status check passed Passed #11395  •  git commit 184e3ca4e0 ℹ️: Merge 6815bcc7a72a402d8209c67d9230691b9c31cb67 into 8610b3f705d9123d8447797afd16...
Project fides
Branch Review refs/pull/5586/merge
Run status status check passed Passed #11395
Run duration 00m 50s
Commit git commit 184e3ca4e0 ℹ️: Merge 6815bcc7a72a402d8209c67d9230691b9c31cb67 into 8610b3f705d9123d8447797afd16...
Committer Andres Torres
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

adamsachs
adamsachs approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving, this looks like the right fix. thanks! 👍

@andres-torres-marroquin
Apply suggestions from code review
6815bcc 
Removing synthetic failure.
@andres-torres-marroquin andres-torres-marroquin merged commit bef6e27 into main Dec 10, 2024
14 checks passed
@andres-torres-marroquin andres-torres-marroquin deleted the andres/HJ-300 branch December 10, 2024 14:28
@cypress Cypress
Copy link

cypress bot commented Dec 10, 2024

fides    Run #11394

Run Properties:  status check passed Passed #11394  •  git commit bef6e27a03: HJ-300 - Adds fail-fast: false to Safe-Tests build strategy (#5586)
Project fides
Branch Review main
Run status status check passed Passed #11394
Run duration 00m 48s
Commit git commit bef6e27a03: HJ-300 - Adds fail-fast: false to Safe-Tests build strategy (#5586)
Committer Andres Torres
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

andres-torres-marroquin added a commit that referenced this pull request Dec 11, 2024
@andres-torres-marroquin
HJ-300 - Adds fail-fast: false to Safe-Tests build strategy (#5586)
be0adae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsachs adamsachs adamsachs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andres-torres-marroquin @adamsachs