Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing datamap Cypress test #5611

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Fixing datamap Cypress test #5611

merged 1 commit into from
Dec 17, 2024

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Dec 16, 2024

Description Of Changes

Updating a Cypress test for the datamap report table now that the undeclared data category columns use the new BadgeCellExpandable component

Code Changes

  • Updated test

Steps to Confirm

  1. Cypress tests should pass

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 11:42pm

Copy link

cypress bot commented Dec 16, 2024

fides    Run #11500

Run Properties:  status check passed Passed #11500  •  git commit 77e91d78f8 ℹ️: Merge 27461167ce2ab8b5998baaaa98434dc287ad8b2e into a74d9463e26eff14125cc3fb7e84...
Project fides
Branch Review refs/pull/5611/merge
Run status status check passed Passed #11500
Run duration 00m 38s
Commit git commit 77e91d78f8 ℹ️: Merge 27461167ce2ab8b5998baaaa98434dc287ad8b2e into a74d9463e26eff14125cc3fb7e84...
Committer Adrian Galvan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@lucanovera lucanovera merged commit 36512e9 into main Dec 17, 2024
13 checks passed
@lucanovera lucanovera deleted the fixing-datamap-cypress-test branch December 17, 2024 14:50
Copy link

cypress bot commented Dec 17, 2024

fides    Run #11517

Run Properties:  status check passed Passed #11517  •  git commit 36512e9897: Fixing datamap Cypress test (#5611)
Project fides
Branch Review main
Run status status check passed Passed #11517
Run duration 00m 49s
Commit git commit 36512e9897: Fixing datamap Cypress test (#5611)
Committer Adrian Galvan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants