Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide buttons to add child labels for Data Subjects #5619

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Hide buttons to add child labels for Data Subjects #5619

merged 1 commit into from
Dec 18, 2024

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Dec 18, 2024 •
edited
Loading

Description Of Changes

Data Subjects don't support parent_keys, so we shouldn't allow creating child labels. Hide the buttons to add a new label, except for the root node.

Code Changes

  • Hide the buttons to add a new Data Subject label, except for the root node.

Steps to Confirm

  1. Go to Taxonomy page
  2. Select Data Subject
  3. Hover over the labels and confirm the Add button is not there
  4. Hover over the root label "Data Subject" and confirm the add button is there and you're able to create a new label

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Dec 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 5:35pm

@lucanovera lucanovera merged commit 2f1242a into main Dec 18, 2024
12 checks passed
@lucanovera lucanovera deleted the fix-data-subject-label-creation branch December 18, 2024 17:48
@cypress Cypress
Copy link

cypress bot commented Dec 18, 2024

fides    Run #11566

Run Properties:  status check passed Passed #11566  •  git commit 02e530eeb3 ℹ️: Merge b7076fc7db5677e64116376c3065b2989735f783 into 4157ac5591125c0190843a769152...
Project fides
Branch Review refs/pull/5619/merge
Run status status check passed Passed #11566
Run duration 00m 54s
Commit git commit 02e530eeb3 ℹ️: Merge b7076fc7db5677e64116376c3065b2989735f783 into 4157ac5591125c0190843a769152...
Committer Lucano Vera
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@cypress Cypress
Copy link

cypress bot commented Dec 18, 2024

fides    Run #11569

Run Properties:  status check passed Passed #11569  •  git commit 2f1242a320: Hide buttons to add child labels for Data Subjects (#5619)
Project fides
Branch Review main
Run status status check passed Passed #11569
Run duration 00m 51s
Commit git commit 2f1242a320: Hide buttons to add child labels for Data Subjects (#5619)
Committer Lucano Vera
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eastandwestwind eastandwestwind eastandwestwind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucanovera @eastandwestwind