Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HJ-128 - Fix on FE columnOrder and CHANGELOG.md update #5623

Merged
merged 1 commit into from
Dec 19, 2024
Merged

HJ-128 - Fix on FE columnOrder and CHANGELOG.md update #5623

merged 1 commit into from
Dec 19, 2024

Conversation

andres-torres-marroquin
Copy link
Contributor

@andres-torres-marroquin andres-torres-marroquin commented Dec 19, 2024 •
edited
Loading

Closes #HJ-128

Description Of Changes

Fix on FE Datamap report columnOrder and adding missing CHANGELOG.md entries.

Code Changes

  • Updated frontend to handle columnOrder properly and added missing CHANGELOG.md entries.

Steps to Confirm

  1. Get a fresh browser (no localstorage variables)
  2. Try to download the report
  3. It should show every single column shown in the website

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Dec 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 5:53pm

@cypress Cypress
Copy link

cypress bot commented Dec 19, 2024

fides    Run #11590

Run Properties:  status check passed Passed #11590  •  git commit 68436a0c7e ℹ️: Merge 0cd596166b39e6d0ba14bc0ab3b04558cfcd3a50 into 5fc96af31d7ee13d0aa15e94b78e...
Project fides
Branch Review refs/pull/5623/merge
Run status status check passed Passed #11590
Run duration 00m 50s
Commit git commit 68436a0c7e ℹ️: Merge 0cd596166b39e6d0ba14bc0ab3b04558cfcd3a50 into 5fc96af31d7ee13d0aa15e94b78e...
Committer Andres Torres
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

gilluminate
gilluminate approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Tested locally in both Chrome and Firefox.

@andres-torres-marroquin andres-torres-marroquin merged commit c8baf75 into main Dec 19, 2024
13 checks passed
@andres-torres-marroquin andres-torres-marroquin deleted the andres/HJ-128-v2 branch December 19, 2024 18:32
@cypress Cypress
Copy link

cypress bot commented Dec 19, 2024

fides    Run #11595

Run Properties:  status check passed Passed #11595  •  git commit c8baf756aa: HJ-128 - Fix on FE columnOrder and CHANGELOG.md update (#5623)
Project fides
Branch Review main
Run status status check passed Passed #11595
Run duration 00m 48s
Commit git commit c8baf756aa: HJ-128 - Fix on FE columnOrder and CHANGELOG.md update (#5623)
Committer Andres Torres
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

andres-torres-marroquin added a commit that referenced this pull request Dec 19, 2024
@andres-torres-marroquin
HJ-128 - Fix on FE columnOrder and CHANGELOG.md update (#5623)
918f233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilluminate gilluminate gilluminate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andres-torres-marroquin @gilluminate