Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creation of new root level labels #5630

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion clients/admin-ui/src/pages/taxonomy/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@ import PageHeader from "~/features/common/PageHeader";
import { errorToastParams, successToastParams } from "~/features/common/toast";
import TaxonomyEditDrawer from "~/features/taxonomy/components/TaxonomyEditDrawer";
import TaxonomyInteractiveTree from "~/features/taxonomy/components/TaxonomyInteractiveTree";
import { CoreTaxonomiesEnum } from "~/features/taxonomy/constants";
import {
CoreTaxonomiesEnum,
TAXONOMY_ROOT_NODE_ID,
} from "~/features/taxonomy/constants";
import useTaxonomySlices from "~/features/taxonomy/hooks/useTaxonomySlices";
import { TaxonomyEntity } from "~/features/taxonomy/types";

Expand Down Expand Up @@ -67,9 +70,11 @@ const TaxonomyPage: NextPage = () => {
return;
}

const isChildOfRoot = draftNewItem?.parent_key === TAXONOMY_ROOT_NODE_ID;
const newItem = {
...draftNewItem,
name: labelName,
parent_key: isChildOfRoot ? null : draftNewItem.parent_key,
};

const result = await createTrigger(newItem);
Expand Down
Loading