-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove patch version pin from redis image tag #5660
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
erosselli
approved these changes
Jan 13, 2025
fides
|
Project |
fides
|
Branch Review |
refs/pull/5660/merge
|
Run status |
|
Run duration | 01m 03s |
Commit |
|
Committer | Dave Quinlan |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
1
|
|
0
|
|
0
|
|
0
|
|
3
|
View all changes introduced in this branch ↗︎ |
Tests for review
cypress/e2e/smoke_test.cy.ts • 1 failed test
Test | Artifacts | |
---|---|---|
Smoke test > can access Mongo and Postgres connectors from the Admin UI |
Screenshots
Video
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5660 +/- ##
=======================================
Coverage 87.13% 87.14%
=======================================
Files 388 388
Lines 24000 24000
Branches 2594 2594
=======================================
+ Hits 20913 20914 +1
Misses 2525 2525
+ Partials 562 561 -1 ☔ View full report in Codecov by Sentry. |
Note: I tested this locally using
|
fides
|
Project |
fides
|
Branch Review |
main
|
Run status |
|
Run duration | 00m 51s |
Commit |
|
Committer | Dave Quinlan |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
4
|
View all changes introduced in this branch ↗︎ |
eastandwestwind
pushed a commit
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unticketed chore
Description Of Changes
redis:6.2.5-alpine
withredis:6.2-alpine
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works