Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove patch version pin from redis image tag #5660

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

daveqnet
Copy link
Contributor

@daveqnet daveqnet commented Jan 13, 2025

Unticketed chore

Description Of Changes

Code Changes

  • See above

Steps to Confirm

  1. Run local fides test env

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 4:36pm

@daveqnet daveqnet requested a review from erosselli January 13, 2025 15:02
Copy link

cypress bot commented Jan 13, 2025

fides    Run #11725

Run Properties:  status check failed Failed #11725  •  git commit c0b6a4503e ℹ️: Merge 93ada615b96c59af01d1211eb41611acca61d5f5 into 7ea4ad58d49dfcd525344fdf1de8...
Project fides
Branch Review refs/pull/5660/merge
Run status status check failed Failed #11725
Run duration 01m 03s
Commit git commit c0b6a4503e ℹ️: Merge 93ada615b96c59af01d1211eb41611acca61d5f5 into 7ea4ad58d49dfcd525344fdf1de8...
Committer Dave Quinlan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 3
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/smoke_test.cy.ts • 1 failed test

View Output Video

Test Artifacts
Smoke test > can access Mongo and Postgres connectors from the Admin UI Screenshots Video

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.14%. Comparing base (7ea4ad5) to head (93ada61).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5660   +/-   ##
=======================================
  Coverage   87.13%   87.14%           
=======================================
  Files         388      388           
  Lines       24000    24000           
  Branches     2594     2594           
=======================================
+ Hits        20913    20914    +1     
  Misses       2525     2525           
+ Partials      562      561    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daveqnet
Copy link
Contributor Author

Note: I tested this locally using nox -s "fides_env(test)" and all worked well.

~ ❯ redis-cli -h localhost -p 7379 -a redispassword
Warning: Using a password with '-a' or '-u' option on the command line interface may not be safe.
localhost:7379> ping
PONG
localhost:7379> info server
# Server
redis_version:6.2.17
redis_git_sha1:00000000
redis_git_dirty:0
redis_build_id:fa1f04a5bd47c674
redis_mode:standalone
os:Linux 6.10.14-linuxkit aarch64
arch_bits:64
monotonic_clock:POSIX clock_gettime
multiplexing_api:epoll
atomicvar_api:c11-builtin
gcc_version:14.2.0
process_id:1
process_supervised:no
run_id:09008bafc025aa3a8020304ecef97245d0891489
tcp_port:6379
server_time_usec:1736787973543365
uptime_in_seconds:279
uptime_in_days:0
hz:10
configured_hz:10
lru_clock:8734725
executable:/data/redis-server
config_file:
io_threads_active:0

@daveqnet daveqnet merged commit 83cb612 into main Jan 13, 2025
37 of 39 checks passed
@daveqnet daveqnet deleted the daveqnet/remove-redis-patch-pin branch January 13, 2025 17:08
Copy link

cypress bot commented Jan 13, 2025

fides    Run #11729

Run Properties:  status check passed Passed #11729  •  git commit 83cb612e4b: chore: remove patch version pin from redis image tag (#5660)
Project fides
Branch Review main
Run status status check passed Passed #11729
Run duration 00m 51s
Commit git commit 83cb612e4b: chore: remove patch version pin from redis image tag (#5660)
Committer Dave Quinlan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants