Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data catalog breadcrumb navigation #5717

Merged
merged 58 commits into from
Feb 3, 2025

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Jan 31, 2025

Closes [HJ-404]

Description Of Changes

Fixes a bug where navigating to higher tables in the data catalog view would sometimes unexpectedly result in empty tables. Also adds icons.

Code Changes

  • Reorganize data catalog tables to be under a /projects/ or /resources/ parent route based on whether the system has a database layer or not
  • Add separate URN-to-breadcrumb mapping also based on whether there's a database layer for the resource
  • Changes system breadcrumb links to link to top-level data catalog view (this is to prevent empty tables if the system pages load without monitor config IDs)

Steps to Confirm

  1. Create data-catalog systems both with (e.g. BigQuery) and without (e.g. DynamoDB) a database layer
  2. Add a monitor to each system and scan
  3. View "data catalog"
  4. Should be able to click through all layers (project -> subfield) for system with database layer; at any level, should be able to navigate back up to higher levels via the breadcrumb
  5. Should be able to click through all layers (dataset -> field) for system without database layer; at any level, should be able to navigate back up to higher levels via the breadcrumb

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2025 8:12pm

Copy link

cypress bot commented Jan 31, 2025

fides    Run #12094

Run Properties:  status check passed Passed #12094  •  git commit 00ef576a2a ℹ️: Merge 2bf687a4af8d884607201d57bda984568f9a6804 into 50f44b8b383d7d16cd95b460b337...
Project fides
Branch Review refs/pull/5717/merge
Run status status check passed Passed #12094
Run duration 00m 48s
Commit git commit 00ef576a2a ℹ️: Merge 2bf687a4af8d884607201d57bda984568f9a6804 into 50f44b8b383d7d16cd95b460b337...
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

@jpople jpople merged commit bfff3d3 into main Feb 3, 2025
20 checks passed
@jpople jpople deleted the jpople/hj-29/data-catalog-navigation-fix branch February 3, 2025 20:40
Copy link

cypress bot commented Feb 3, 2025

fides    Run #12095

Run Properties:  status check passed Passed #12095  •  git commit bfff3d313d: Fix data catalog breadcrumb navigation (#5717)
Project fides
Branch Review main
Run status status check passed Passed #12095
Run duration 00m 48s
Commit git commit bfff3d313d: Fix data catalog breadcrumb navigation (#5717)
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants