-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix data catalog breadcrumb navigation #5717
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…taset-lifecycle-top-tables
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides Run #12094
Run Properties:
|
Project |
fides
|
Branch Review |
refs/pull/5717/merge
|
Run status |
Passed #12094
|
Run duration | 00m 48s |
Commit |
00ef576a2a ℹ️: Merge 2bf687a4af8d884607201d57bda984568f9a6804 into 50f44b8b383d7d16cd95b460b337...
|
Committer | jpople |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
5
|
View all changes introduced in this branch ↗︎ |
gilluminate
approved these changes
Feb 3, 2025
fides Run #12095
Run Properties:
|
Project |
fides
|
Branch Review |
main
|
Run status |
Passed #12095
|
Run duration | 00m 48s |
Commit |
bfff3d313d: Fix data catalog breadcrumb navigation (#5717)
|
Committer | jpople |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
5
|
View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes [HJ-404]
Description Of Changes
Fixes a bug where navigating to higher tables in the data catalog view would sometimes unexpectedly result in empty tables. Also adds icons.
Code Changes
/projects/
or/resources/
parent route based on whether the system has a database layer or notSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works