Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed link for changelog #5728

Merged
merged 1 commit into from
Feb 3, 2025
Merged

fixed link for changelog #5728

merged 1 commit into from
Feb 3, 2025

Conversation

JadeCara
Copy link
Contributor

@JadeCara JadeCara commented Feb 3, 2025

Description Of Changes

Fixed a changelog link to point at the PR as intended.

Code Changes

  • updated Changelog with correct link

Steps to Confirm

  1. Click link in Changelog to verify it takes you to the PR.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Feb 3, 2025 9:56pm

@JadeCara JadeCara marked this pull request as ready for review February 3, 2025 21:56
andres-torres-marroquin
andres-torres-marroquin approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@andres-torres-marroquin andres-torres-marroquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for taking care of this

@JadeCara JadeCara merged commit da19f8b into main Feb 3, 2025
12 checks passed
@JadeCara JadeCara deleted the jade/fix_changelog_typo20250203 branch February 3, 2025 21:59
@cypress Cypress
Copy link

cypress bot commented Feb 3, 2025

fides    Run #12101

Run Properties:  status check passed Passed #12101  •  git commit da19f8b328: fixed link for changelog (#5728)
Project fides
Branch Review main
Run status status check passed Passed #12101
Run duration 00m 49s
Commit git commit da19f8b328: fixed link for changelog (#5728)
Committer JadeWibbels
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andres-torres-marroquin andres-torres-marroquin andres-torres-marroquin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JadeCara @andres-torres-marroquin