Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nav menu as links #5759

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Feb 13, 2025

Closes LJ-374

Description Of Changes

Update nav menu to use NextLink instead of onClick for routing

Steps to Confirm

  1. Main menu can be focusable using keyboard tab key or arrows and pressing the Return key activates the link to navigate.
  2. Main menu allows user to Command + Click to open links in new tab
  3. Main menu allows user to right click + open in new tab

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@gilluminate gilluminate requested a review from jpople February 13, 2025 17:04
Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 6:52pm

@gilluminate gilluminate merged commit bf2d220 into main Feb 13, 2025
17 checks passed
@gilluminate gilluminate deleted the gill/LJ-374/new-nav-links-arent-links branch February 13, 2025 18:55
gilluminate added a commit that referenced this pull request Feb 13, 2025
Copy link

cypress bot commented Feb 13, 2025

fides    Run #12466

Run Properties:  status check passed Passed #12466  •  git commit bf2d220740: update nav menu as links (#5759)
Project fides
Branch Review main
Run status status check passed Passed #12466
Run duration 00m 48s
Commit git commit bf2d220740: update nav menu as links (#5759)
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants