Update Docs #74
Update Docs #74
Conversation
|
@iamkelllly is this good to merge now or are there other changes you want in? |
|
@ThomasLaPiana sorry! not ready yet, i was trying to find the "draft" button somewhere and i couldn't find it so i just published a PR lol i have a few other things to add so EOD today should be good to review. It's all mostly documentation updates and md cleanup |
|
@iamkelllly no worries! Just wanted to confirm, when its ready for a review and merge just assign me as the reviewer and i'll take that as "its ready" :) |
|
@iamkelllly are you ok to also include changes for #72 here? i can dogpile onto this PR instead of opening a new one and dealing with potential merge conflicts |
|
@NevilleS would love to get some feedback on the deployment guide It's extremely sticky work, and I'm not sure how exactly to take it since there are so many different ways to deploy it... |
finished writing the "five easy steps" though it's really not that easy
Reworded, reorg'ed and reduced repeats
style tings
* Add foundation to make Redshift access request queries. * Fix connection config and dataset config tests that look at a new dataset being added. * Add support for performing redshift erasures. * Only mask state field in erasure test - contact is too broad, and was preventing the customer record from getting cleaned up. * Remove unnecessary assertion and access values as attributes of RowProxy not tuples. * Add Amazon Redshift example to docs. * Remove breakpoint, argh. * Use SQLAlchemy TextClause instead of passing in raw string. * Add request attribute to mask_data and pass into generate_update_stmt.
* Add foundation to make Redshift access request queries. * Fix connection config and dataset config tests that look at a new dataset being added. * Add support for performing redshift erasures. * Only mask state field in erasure test - contact is too broad, and was preventing the customer record from getting cleaned up. * Remove unnecessary assertion and access values as attributes of RowProxy not tuples. * Add Amazon Redshift example to docs. * Remove breakpoint, argh. * Use SQLAlchemy TextClause instead of passing in raw string. * Add request attribute to mask_data and pass into generate_update_stmt.
Closes #72
Code Changes
quick guidesection (replaced by a better proper tutorial on that page)/docsto reflect the new methodmake docs-servegetting startedpage, strongly biasing towards docker and making sure that works cleanlySteps to Confirm
Pre-Merge Checklist
Description Of Changes
Write some things here about the changes and any potential caveats