Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[820] ui/form: Password input #822

Merged
merged 4 commits into from
Jun 29, 2022
Merged

[820] ui/form: Password input #822

merged 4 commits into from
Jun 29, 2022

Conversation

ssangervasi
Copy link
Contributor

@ssangervasi ssangervasi commented Jun 29, 2022 •
edited
Loading

Closes #820

Code Changes

  • Add new icon: Eye
  • Detect "password" type for custom input and add show/hide toggling
  • Use in AWS form

Steps to Confirm

show-hide-pwd

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Write some things here about the changes and any potential caveats

@ssangervasi ssangervasi requested review from LKCSmith, allisonking and a team and removed request for LKCSmith June 29, 2022 00:38
allisonking
allisonking approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ssangervasi ssangervasi merged commit 487868c into main Jun 29, 2022
@ssangervasi ssangervasi deleted the ssangervasi/820/password-input branch June 29, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisonking allisonking allisonking approved these changes

@LKCSmith LKCSmith Awaiting requested review from LKCSmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom password input w/ reveal for AWS secret
2 participants
@ssangervasi @allisonking