Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaffold taxonomy page #902

Merged
merged 7 commits into from
Jul 18, 2022
Merged

Scaffold taxonomy page #902

merged 7 commits into from
Jul 18, 2022

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Jul 14, 2022

Closes #852

Code Changes

  • Make /taxonomy page to be reachable via the navbar
  • Update taxonomy page to have tabs for each taxonomy entity, like in the design
  • Cypress tests + fixtures for taxonomy page
  • Fixed some types with the data-use and data-qualifier slices. Also tried to standardize their pluralization, so some changes in PrivacyDeclarationForm.tsx as well

Steps to Confirm

  • nox -s dev and then visit localhost:3000/taxonomy

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

The content of the tab is just listed out as simply as possible right now, but will be updated to match the designs in #853

Screen.Recording.2022-07-14.at.2.57.45.PM.mov

The design for each tab should be the same, so I made a TaxonomyTabContent component that will do the rendering based on different data. Hopefully all of the tabs will be able to use it and just pass in different functions to handle adding, editing, deleting, etc.

@allisonking allisonking marked this pull request as ready for review July 14, 2022 19:01
@allisonking allisonking requested a review from a team July 14, 2022 19:01
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@allisonking allisonking merged commit ecbf345 into main Jul 18, 2022
@allisonking allisonking deleted the aking-852-scaffold-taxonomy branch July 18, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scaffold out taxonomy management page
2 participants