Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace config file string with a constant of the path #933

Merged
merged 2 commits into from
Jul 22, 2022

Conversation

SteveDMurphy
Copy link
Contributor

@SteveDMurphy SteveDMurphy commented Jul 21, 2022

Closes #932

Code Changes

  • Replace "fidesctl.toml" with DEFAULT_CONFIG_PATH

Steps to Confirm

  • A local install of fidesctl can read the config and start the webserver

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Another hangup that keeps being found here is the need to manually add the port to the default config. Maybe worth taking a look there to ease startup steps/pain?

I think a good test for this may be to try and validate the webserver without passing the config, but not sure if that makes sense or not as of yet

Testing this PR requires a running db, so executing docker compose up -d fidesctl-db is a prereq

@SteveDMurphy SteveDMurphy self-assigned this Jul 21, 2022
@SteveDMurphy SteveDMurphy marked this pull request as ready for review July 21, 2022 19:48
@SteveDMurphy SteveDMurphy requested a review from a team July 21, 2022 19:48
Copy link
Contributor

@sanders41 sanders41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@SteveDMurphy SteveDMurphy merged commit 32baffe into main Jul 22, 2022
@SteveDMurphy SteveDMurphy deleted the SteveDMurphy-932-default-config-location branch July 22, 2022 02:14
@ThomasLaPiana
Copy link
Contributor

@SteveDMurphy I totally hit this bug the other day and made a mental note to go back and figure out the cause! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default config file location missing .fides parent directory
3 participants