Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging section table format fix #969

Merged
merged 1 commit into from
Aug 8, 2022
Merged

logging section table format fix #969

merged 1 commit into from
Aug 8, 2022

Conversation

ArpanBalpande
Copy link
Contributor

@ArpanBalpande ArpanBalpande commented Aug 6, 2022 •
edited
Loading

Closes

Code Changes

  • added formatting change for logging section.

Steps to Confirm

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Write some things here about the changes and any potential caveats

@ArpanBalpande ArpanBalpande requested a review from a team August 6, 2022 02:20
@sanders41 sanders41 linked an issue Aug 7, 2022 that may be closed by this pull request
Fix formatting of logging config variables #967
Closed
conceptualshark
conceptualshark approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@conceptualshark conceptualshark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArpanBalpande Thank you so much for this fix!

@conceptualshark conceptualshark merged commit 342d925 into ethyca:main Aug 8, 2022
@ArpanBalpande ArpanBalpande deleted the fix-logging-section-format branch August 10, 2022 16:57
@ArpanBalpande
Copy link
Contributor Author

Thanks for accepting the PR. @conceptualshark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conceptualshark conceptualshark conceptualshark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix formatting of logging config variables
2 participants
@ArpanBalpande @conceptualshark