-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include fides_key in datamap api output #992
Conversation
@SteveDMurphy I really appreciate you getting started on this, despite feeling under the weather, and I hope you are feeling better or at least taking the time to feel better!! 🍵 Let me know when you think this is good for the FE to test with. |
Thanks @LKCSmith !! This at least has the fides key(s) for system and dataset included, so that may be enough to start. I am going to experiment with pulling in the system dependencies as well this morning but hoping you can get an early start |
@LKCSmith both |
@SteveDMurphy Thank you! I'll try this out today 🚀 |
@SteveDMurphy - One last request (if it makes sense to you) - is it possible to also include the |
Thanks for the heads up @LKCSmith ! I don't see any issue with including it as well, anything to we can do to make rendering the datamap a bit easier 👍🏽. The only problem I foresee is if there are a large number of rows for a single system (thinking many data categories) we end up duplicating a bunch of data unnecessarily for each row. I think this is likely a problem we can address down the road however and just focus on driving ahead here. Will get that added either later tonight or first thing in the morning so you can drop that additional query, thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the speedy unblocking action here :)
Thanks for the lightning fast review!! ⚡ ⚡ |
Closes #987
Code Changes
fides_key
for system and dataset rows returned by the/datamap
enpointSteps to Confirm
fides_key
of items in the data mapPre-Merge Checklist
CHANGELOG.md
Description Of Changes
This is not pretty but wanted to get a start out for this quickly as it sounds like a potential blocking item