-
Notifications
You must be signed in to change notification settings - Fork 16
Subject Request Events and Logs Section #1018
Conversation
Hey @TheAndrewJackson, what data have you been using to test this? Did you write a script or are you running requests through and using the logs? Just thinking a script might help because we can be sure it covers every edge case. |
I've been manually creating, or mocking, some of the data on the frontend. I created the execution logs by following the "Minimum API calls to create an Access Privacy Request" directory in our Postman collection. I agree that a script would be really helpful. Maybe the |
onClose(); | ||
}; | ||
|
||
const headerText = isViewingError ? "Event detail" : "Event log"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we think about having this popover update the URL? I could imagine a user wanting to share event logs for request failures for instance, as that's where the trace will be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. That's a good idea but it won't work right now because our current BE router isn't able to resolve dynamic urls. Once we decide on a solution for dynamic urls we will be able support features like this.
Are you okay with adding this in a future PR once that BE supports this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! Have made a ticket
Thanks @TheAndrewJackson — LGTM once we've addressed that question on the URLs |
We'd need to actually process the requests created, which means we'll need to run the server (rather than just access the DB directly). I'll have a play around this morning and see if that's an easy enough restructure. More broadly we need to get better at planning test data in for these frontend features. |
* Fix small issue with eslint config * Get initial drawer working * Add jest config to eslintignore * Fix small css issue * Refactor components and get initial functionality * Fix small logic error * Fix couple of bugs and format code * Conditinally display error tag * Fix issues with merge * Format and lint * Sort imports * Update to new solution * Format code * Update changelog Co-authored-by: Sean Preston <sean@ethyca.com>
Purpose
Add Events and Logs to the Subject Request Details page. This PR implements everything that's possible right now. In order to finish out the whole issue the backend needs to add some additional logs for the activity timeline. This is a stop gap to merge in what's currently working. Once the backend has added everything that's needed a followup PR will finish this feature.
Changes
Checklist
CHANGELOG.md
fileCHANGELOG.md
file is being appended toUnreleased
section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checks
label has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #495