Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

doc updates for saas request overrides #1229

Merged
merged 7 commits into from
Sep 22, 2022

Conversation

conceptualshark
Copy link
Contributor

@conceptualshark conceptualshark commented Aug 31, 2022

Purpose

#815 allows developers to extend their saas configs with custom python functions. These updated docs explain how to do this in full.

Changes

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #

@conceptualshark conceptualshark linked an issue Aug 31, 2022 that may be closed by this pull request
@conceptualshark conceptualshark changed the title 995 doc updates for saas request overrides doc updates for saas request overrides Aug 31, 2022
@conceptualshark conceptualshark marked this pull request as ready for review August 31, 2022 14:16
Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@eastandwestwind
Copy link
Contributor

oh @conceptualshark mind pulling latest main, and moving the changelog line to the unreleased section?

@eastandwestwind eastandwestwind merged commit 0385704 into main Sep 22, 2022
@eastandwestwind eastandwestwind deleted the 995-doc-updates-for-saas-request-overrides branch September 22, 2022 15:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc updates for SaaS request overrides
2 participants