Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Add consent request table #1340

Merged
merged 4 commits into from
Sep 19, 2022
Merged

Add consent request table #1340

merged 4 commits into from
Sep 19, 2022

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Sep 17, 2022 •
edited
Loading

Purpose

❗ Contains a migration

Adds a table to track consent requests

Changes

  • Added a consent request table

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #1322

@sanders41 sanders41 changed the title Add consent crequest table Add consent request table Sep 17, 2022
TheAndrewJackson
TheAndrewJackson approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheAndrewJackson TheAndrewJackson merged commit 03f6fdc into main Sep 19, 2022
@TheAndrewJackson TheAndrewJackson deleted the ps-consent-request-table branch September 19, 2022 15:59
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
Add consent request table (#1340)
337e2f1 
* Add consent crequest table

* Update changelog

* Fix isort and black

Co-authored-by: Paul Sanders <pau@ethyca.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TheAndrewJackson TheAndrewJackson TheAndrewJackson approved these changes

Assignees

@TheAndrewJackson TheAndrewJackson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ConsentRequest table
2 participants
@sanders41 @TheAndrewJackson