Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Initial Refactor for Consent Intake UI #1363

Merged
merged 9 commits into from
Sep 21, 2022
Merged

Initial Refactor for Consent Intake UI #1363

merged 9 commits into from
Sep 21, 2022

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Sep 21, 2022 •
edited
Loading

Purpose

This PR doesn't contain any of the consent UI code. It's purpose is to refactor the privacy center to be more modular. This will make easier to add the consent UI and make the next PR that merges in smaller and easier to read.

Changes

  • Refactor out styling logic from PrivacyCard into base Card component
  • Refactor out the higher level modal styling and html structure into a base RequestModal
  • Refactor the VerificationForm component to be generic making it easier to add consent verification in the future

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #

@TheAndrewJackson TheAndrewJackson changed the title 1319 consent intake UI Initial Refactor for Consent Intake UI Sep 21, 2022
@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review September 21, 2022 16:58
eastandwestwind
eastandwestwind approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and confirmed privacy center works locally

@eastandwestwind eastandwestwind merged commit 5e6174e into main Sep 21, 2022
@eastandwestwind eastandwestwind deleted the 1319_consent_intake_ui branch September 21, 2022 17:23
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
@TheAndrewJackson
Initial Refactor for Consent Intake UI (#1363)
bdd9f44 
* Refactor Card markup out and create ConsentCard

* Refactor Modals and create Consent page items

* Make `VerificationForm` generic

* Remove consent code

* Remove consent.svg

* Remove consent config options

* Update CHANGELOG.md

* Switch policy_key back to download
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eastandwestwind eastandwestwind eastandwestwind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheAndrewJackson @eastandwestwind