Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Adding missing import #448

Merged
merged 2 commits into from
May 3, 2022
Merged

Adding missing import #448

merged 2 commits into from
May 3, 2022

Conversation

galvana
Copy link
Collaborator

@galvana galvana commented May 2, 2022

Purpose

To fix linter issue on main where fidesops.core.config is missing from saas_connector.py

Changes

  • adding missing import

Checklist

  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

@pattisdr
Copy link
Contributor

pattisdr commented May 2, 2022

Thanks for jumping on this @galvana!

@seanpreston seanpreston added the run unsafe ci checks Triggers running of unsafe CI checks label May 3, 2022
@sanders41 sanders41 mentioned this pull request May 3, 2022
Closed
@eastandwestwind eastandwestwind mentioned this pull request May 3, 2022
Merged
6 tasks
@galvana galvana added run unsafe ci checks Triggers running of unsafe CI checks and removed run unsafe ci checks Triggers running of unsafe CI checks labels May 3, 2022
@seanpreston
Copy link
Contributor

I'm merging this now to fix the pipelines in other branches, and we can fix the failing external integration tests in a subsequent PR.

@seanpreston seanpreston merged commit 51e73e8 into main May 3, 2022
@seanpreston seanpreston deleted the debug-mode-linter-fix branch May 3, 2022 18:57
adamsachs pushed a commit to adamsachs/fidesops_forked_test that referenced this pull request May 17, 2022
@galvana
Adding missing import (ethyca#448)
fe43efe 
* Adding missing import

* Fixing Mailchimp tests to use the updated masking function
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
@galvana
Adding missing import (#448)
d7a5e6d 
* Adding missing import

* Fixing Mailchimp tests to use the updated masking function
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@seanpreston seanpreston seanpreston approved these changes

Assignees
No one assigned
Labels
run unsafe ci checks Triggers running of unsafe CI checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galvana @pattisdr @seanpreston