Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Add __init__.py files to all directories where they're currently missing #590

Merged
merged 4 commits into from
Jun 2, 2022

Conversation

PSalant726
Copy link
Contributor

Purpose

When installing fidesops via pip, the /migrations directory is omitted despite being specifically included in the MANIFEST.in registry since #566.

Changes

  • Add an __init__.py file to the /src/migrations directory
  • Add an __init__.py file to all sub-directories of /src/migrations that contain *.py files
  • Add __init__.py files anywhere else they may be missing

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #589

@PSalant726 PSalant726 added enhancement New feature or request dev experience Enhancements to the overall DX run unsafe ci checks Triggers running of unsafe CI checks labels Jun 2, 2022
@PSalant726 PSalant726 self-assigned this Jun 2, 2022
@sanders41 sanders41 merged commit dd60b62 into main Jun 2, 2022
@sanders41 sanders41 deleted the even-more-init-files branch June 2, 2022 23:11
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
…ssing (#590)

* Add missing `__init__.py` files to /src packages

* Add missing `__init__.py` files to /test packages

* Update `CHANGELOG.md`

* Consolidate 'Added' changes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dev experience Enhancements to the overall DX enhancement New feature or request run unsafe ci checks Triggers running of unsafe CI checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add __init__.py files to /migrations, and everywhere else they may be missing
2 participants