This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattisdr
commented
Jun 14, 2022
src/fidesops/migrations/versions/55d61eb8ed12_add_default_policies.py
Outdated
Show resolved
Hide resolved
…policies # Conflicts: # CHANGELOG.md Bump downrev.
seanpreston
reviewed
Jun 14, 2022
src/fidesops/migrations/versions/55d61eb8ed12_add_default_policies.py
Outdated
Show resolved
Hide resolved
pattisdr
commented
Jun 15, 2022
pattisdr
commented
Jun 15, 2022
src/fidesops/migrations/versions/55d61eb8ed12_add_default_policies.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple questions related to docs:
- Should we add to docs somewhere that these Policies are already created by default, to avoid confusion?
Some places in docs where this might make sense- https://ethyca.github.io/fidesops/postman/using_postman/
https://ethyca.github.io/fidesops/guides/policies/
- test mode / dev mode do diff things and can be confusing to someone first looking at config vars. I think it would be useful to better clarify in docs what setting these vars actually do, perhaps in a separate PR.
Thanks @eastandwestwind I'll look into clarifying these items in the docs |
…policies # Conflicts: # CHANGELOG.md
…v variable is primarily set by pytest.
@ethyca/docs-authors minor docs added to describe the two autogenerated policies that ship with Fidesops and clarify that the TESTING variable is set by Pytest for when we run unit tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pattisdr , thumbs up from me!
seanpreston
reviewed
Jun 15, 2022
Co-authored-by: Cole Isaac <82131455+conceptualshark@users.noreply.github.com>
seanpreston
approved these changes
Jun 15, 2022
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
* WIP: Add a data migration that autogenerates a default 'download' and 'delete' policy. * Bump downrev and add logging for data migration steps. * Try importing models from db.base. * Use the connection currently being used to emit SQL to the database. * Skip adding default policies to test database. * Refactor so we're querying in SQL and not relying on SQLAlchemy models. * Add default policies to policy guides and clarify that the TESTING env variable is primarily set by pytest. * Update docs/fidesops/docs/guides/policies.md Co-authored-by: Cole Isaac <82131455+conceptualshark@users.noreply.github.com> Co-authored-by: Cole Isaac <82131455+conceptualshark@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Contains data migration; check downrev before merging
Purpose
Ship Fidesops with two default Policies:
download
anddelete
so Fidesops instances can run privacy requests right away.The policies are created as a data migration.
Changes
Adds a data migration that:
download
policy does not exist, create one, with a Rule using the localstorage and the the RuleTarget looking at identifiable data, with the autogenerated client abovedelete
policy does not exist, create one, with a Rule that using a string masking strategy, targeting identifiable data, with the autogenerated client aboveNote: this does not create resources in test mode (pytest)
Checklist
CHANGELOG.md
fileCHANGELOG.md
file is being appended toUnreleased
section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checks
label has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #624