Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

[SaaS Connector] Salesforce (access) #676

Merged
merged 24 commits into from
Jun 24, 2022

Conversation

galvana
Copy link
Collaborator

@galvana galvana commented Jun 16, 2022

Purpose

Adds Salesforce connector with access functionality

Changes

The Salesforce APIs cover a broad scope of functionality so for this first pass we will only be covering the following collections

  • Contacts
  • Cases
  • Leads
  • Campaign Members
  • Accounts

We have added these files:

  • Config file salesforce_config.yml for configuration
  • Dataset file salesforce_data.yml
  • Test cases file test_salesesforce_task.py and salesforce_fixtures.py for testing
  • Utility test file saas_tets_utility.py

We have updated these files:

  • saas_config.toml to contain Salesforce data
  • conftest.py to add Salesforce test

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Good unit test/integration test coverage

Ticket

Fixes #398

@galvana galvana marked this pull request as ready for review June 17, 2022 20:50
@galvana galvana requested a review from adamsachs June 21, 2022 18:01
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just need a very minor change to fixture method name that was copy and pasted - the method isn't being used yet but let's clean it up now anyway.

also, i think it's fine to include the poll_for_existence refactor on this PR even though it's not being explicitly used, but may be good to make the core fidesops team aware just as an FYI. i also assume we've tested (or CI has covered) that the refactor hasn't broken anything in existing saas integration tests.



@pytest.fixture(scope="function")
def stripe_create_erasure_data(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we forgot to change the method name from stripe to salesforce -- that was probably in my initial work, whoops :)

@galvana galvana requested a review from adamsachs June 21, 2022 18:54
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@galvana galvana added the run unsafe ci checks Triggers running of unsafe CI checks label Jun 24, 2022
@galvana galvana added run unsafe ci checks Triggers running of unsafe CI checks and removed run unsafe ci checks Triggers running of unsafe CI checks labels Jun 24, 2022
@galvana galvana added run unsafe ci checks Triggers running of unsafe CI checks and removed run unsafe ci checks Triggers running of unsafe CI checks labels Jun 24, 2022
@galvana galvana added run unsafe ci checks Triggers running of unsafe CI checks and removed run unsafe ci checks Triggers running of unsafe CI checks labels Jun 24, 2022
@galvana galvana added run unsafe ci checks Triggers running of unsafe CI checks and removed run unsafe ci checks Triggers running of unsafe CI checks labels Jun 24, 2022
@galvana galvana merged commit 89c0a3d into main Jun 24, 2022
@galvana galvana deleted the 398-saas-connector-salesforce-due-615 branch June 24, 2022 23:47
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
Co-authored-by: Adam Sachs <adam@Adams-MacBook-Pro.local>
Co-authored-by: Hamza W <hamza@Hamzas-MacBook-Pro.local>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
run unsafe ci checks Triggers running of unsafe CI checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SaaS Connector] Salesforce - ACCESS (DUE 6/15)
2 participants