-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just need a very minor change to fixture method name that was copy and pasted - the method isn't being used yet but let's clean it up now anyway.
also, i think it's fine to include the poll_for_existence
refactor on this PR even though it's not being explicitly used, but may be good to make the core fidesops team aware just as an FYI. i also assume we've tested (or CI has covered) that the refactor hasn't broken anything in existing saas integration tests.
|
||
|
||
@pytest.fixture(scope="function") | ||
def stripe_create_erasure_data( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like we forgot to change the method name from stripe
to salesforce
-- that was probably in my initial work, whoops :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Co-authored-by: Adam Sachs <adam@Adams-MacBook-Pro.local> Co-authored-by: Hamza W <hamza@Hamzas-MacBook-Pro.local>
Purpose
Adds Salesforce connector with access functionality
Changes
The Salesforce APIs cover a broad scope of functionality so for this first pass we will only be covering the following collections
We have added these files:
We have updated these files:
Checklist
CHANGELOG.md
fileCHANGELOG.md
file is being appended toUnreleased
section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Ticket
Fixes #398