This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Endpoint: Return Secrets for a Connector Type [#753] #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptions and saas options.
- Add docs and postman collection.
… for a given connection type. - Relocate "load_config" which we use to load saas config yamls, now that we have another use case beyond unit tests.
…tor type, so the description isn't abstract. - Update changelog - Add docs - Add endpoint to postman collection
|
@ethyca/docs-authors Minor section added to the guides around how to get the types of secrets needed to authenticate with a given connector |
There was a problem hiding this comment.
Looks good overall @pattisdr !
Just some minor comments, nothing blocking.
src/fidesops/schemas/connection_configuration/connection_secrets_saas.py
Outdated
Show resolved
Hide resolved
seanpreston
reviewed
Jul 6, 2022
# Conflicts: # src/fidesops/schemas/saas/saas_config.py
…cret_schemas # Conflicts: # CHANGELOG.md # tests/fixtures/saas/zendesk_fixtures.py
…cret_schemas # Conflicts: # tests/api/v1/endpoints/test_connection_template_endpoints.py
…cret_schemas # Conflicts: # tests/api/v1/endpoints/test_connection_template_endpoints.py
CHANGELOG.md
Outdated
Comment on lines
56
to
58
| * Fix console warning in disable connection modal [#750](https://github.com/ethyca/fidesops/pull/750) | ||
| * Fix no such container error with docker-compose [#758](https://github.com/ethyca/fidesops/pull/758) | ||
| * Fixed issue with extending the configuration [#721](https://github.com/ethyca/fidesops/pull/721) |
There was a problem hiding this comment.
@pattisdr it looks like these lines were removed from the changelog, is this intentional?
There was a problem hiding this comment.
good catch thank you, just a really messy merge
eastandwestwind
approved these changes
Jul 6, 2022
10 tasks
10 tasks
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
* Adds Saas type to saas yaml config * alter postman collection * updates changelog * lint fixes * Add endpoint to surface all available connectors including database options and saas options. * Exclude custom and manual types from list of available connectors. - Add docs and postman collection. * Update changelog. * Add an endpoint to fetch the types of secrets that should be supplied for a given connection type. - Relocate "load_config" which we use to load saas config yamls, now that we have another use case beyond unit tests. * Dynamically override the SaaSSchema docstring for a given saas connector type, so the description isn't abstract. - Update changelog - Add docs - Add endpoint to postman collection * Add missing import. * Add a request method to docs. * Update docstring. * Remove committed ANALYTICS_ID. * Import ClientDetail from fideslib instead of fidesops. * Fix import order. * Restore removed items in changelog. Co-authored-by: eastandwestwind <eastandwestwind@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Dependent on #768 . Merge that first.
Purpose
To enable UI users to configure datastores from the UI, we need to create a way to tell the frontend what types of secrets are needed for each connector. Because each database and SaaS app have differing authentication requirements, we need a modular front end that can display 1 to many secrets (on the scale of 2 to 6).
Changes
Checklist
CHANGELOG.mdfileCHANGELOG.mdfile is being appended toUnreleasedsection in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #753