Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Replace user authentication routes with fideslib routes #811

Merged
merged 5 commits into from
Jul 7, 2022

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Jul 6, 2022

Purpose

Use user authentication routes from fideslib

Changes

  • Replaces create_user with fideslib version
  • Replaces delete_user with fideslib version
  • Replaces get_user with fideslbi version
  • Replaces get_users with fideslib version
  • Replaces user_login with fideslib version

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #461

@sanders41 sanders41 changed the title Fideslib routes Replace user authentication routes with fideslib routes Jul 6, 2022
Copy link
Contributor

@pattisdr pattisdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, I might get up to date with main one last time before merging just to make sure tests still pass.

@pattisdr
Copy link
Contributor

pattisdr commented Jul 7, 2022

^ Unrelated mssql error, will merge.

@pattisdr pattisdr merged commit d05eb2c into main Jul 7, 2022
@pattisdr pattisdr deleted the fideslib-routes branch July 7, 2022 14:46
@TheAndrewJackson TheAndrewJackson mentioned this pull request Jul 11, 2022
10 tasks
sanders41 added a commit that referenced this pull request Sep 22, 2022
Co-authored-by: Paul Sanders <pau@ethyca.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace User authentication views with those imported from fideslib
2 participants