This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
745 - [Datastore Management] Keep datastore cards in 1/3 screen pattern #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the Datastore Management column border layout design to match Figma.
|
The 1/3 change looks great! As a side note, it looks a little unfinished to me without a bottom border. |
|
@pattisdr Thanks for the feedback. Added the bottom border now.
Here is the Figma design. You will notice the bottom row is bottom borderless. I will verify with Adria and Simon first thing in the morning to get a consensus.
|
|
If there is more than one row and the row is complete (contains 3 cards) will a bottom border be displayed from my discussion with Simon based on the Figma design.
|
TheAndrewJackson
approved these changes
Jul 18, 2022
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
…rn (#873) * 745 - [Datastore Management] Keep datastore cards in 1/3 screen pattern * 745 - [Datastore Management] Keep datastore cards in 1/3 screen pattern Refactored the Datastore Management column border layout design to match Figma. * Updated CHANGELOG.md file * 45 - [Datastore Management] Keep datastore cards in 1/3 screen pattern * 745 - [Datastore Management] Keep datastore cards in 1/3 screen pattern * Fixed import statement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
-When only 1 or 2 connections exist, the datastore cards stretch to fill the screen. In the mocks they're a consistent 1/3 of the screen.
Changes
Datastore Management should have a 3 column layout which is consistent with Figma design.
Checklist
CHANGELOG.mdfileCHANGELOG.mdfile is being appended toUnreleasedsection in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #745