Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

252 saas connector sendgrid #883

Merged
28 commits merged into from
Jul 19, 2022
Merged

252 saas connector sendgrid #883

Changes from 2 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
1c1fb89
initial sendgrid saas connector integration. access only, contacts only
May 2, 2022
03a9b6e
erasure (update) support for sendgrid
May 4, 2022
f600992
remove unused imports
May 4, 2022
1e2e82d
Merge branch 'main' into 252-saas-connector-sendgrid
May 4, 2022
1c2eab2
Merge branch 'main' into 252-saas-connector-sendgrid
May 9, 2022
ecf689e
update sendgrid test fixture to expect 404 response status code becau…
May 9, 2022
284c878
Fixing import order and cleaning up the retry logic for consistency
galvana May 10, 2022
5b41555
add sendgrid env var support to makefile and unsafe_pr_checks config.…
May 10, 2022
e7d8549
Merge branch 'main' into 252-saas-connector-sendgrid
galvana Jun 11, 2022
fcb05fb
Added delete endpoint for contacts
Jul 14, 2022
3b063a0
Fixing data_path for contacts endpoint
galvana Jul 14, 2022
4573de4
Main branch pull and some related configuration changes added
Jul 14, 2022
2e2c19e
Reverting search query to improve performance and avoid server timeouts
galvana Jul 15, 2022
61ff754
Updated delete endpoint request, used request instead of SaaSRequest …
Jul 15, 2022
230c7e6
updated imports after check suggestion
Jul 15, 2022
c31637f
Updated code after review
Jul 18, 2022
f5a6cd0
Removed unused variables, imports
Jul 18, 2022
6cb18ae
Merging in main
galvana Jul 18, 2022
c01e13c
Restoring Makefile
galvana Jul 18, 2022
f1a2bb1
Fixed import cryptographic_util error
Jul 18, 2022
a2d99cf
Misc fixes
galvana Jul 18, 2022
f00990f
Updated Changelog file
Jul 19, 2022
7f47682
Merge branch '252-saas-connector-sendgrid' of github.com:ethyca/fides…
Jul 19, 2022
4e1df74
Merge branch 'main' of github.com:ethyca/fidesops into 252-saas-conne…
Jul 19, 2022
227239f
Updated Changelog for unreleased section and pulled main
Jul 19, 2022
2368e2d
Updated Changelog and added Sendgrid in unreleased section
Jul 19, 2022
ba650ac
Updated Changelog and added Sendgrid in unreleased section with link
Jul 19, 2022
a392415
Updated Changelog and added Sendgrid in added section after Adam's su…
Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ The types of changes are:
* Adds endpoint analytics events [#622](https://github.com/ethyca/fidesops/pull/622)
* Sample dataset for Salesforce with access configuration [#676](https://github.com/ethyca/fidesops/pull/676)
* Sample dataset and access configuration for Zendesk (ticket endpoints) [#677](https://github.com/ethyca/fidesops/pull/677)
* Sample dataset for Sendgrid with access configuration [#883](https://github.com/ethyca/fidesops/pull/883)
Copy link
Contributor

@adamsachs adamsachs Jul 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HamzaWaseemOnBench please follow the instructions provided in the PR template that describe how to update the CHANGELOG.md file. there are a few things you need to do here:

  • merge in main so the most recent CHANGELOG.md file is being appended to. this is to avoid merge conflicts in the file.
  • your description for this feature needs to be added in the Unreleased section, since you are not adding this feature to the 1.6.0 release, but you're adding it to the next upcoming release. You can also refer to the Keep a Changelog documentation for more information about how to update the changelog.
  • the description you gave here doesn't really capture the full scope of your changes - i think a more accurate description would read something like: "Access and erasure support for Sendgrid contacts endpoint"

* Include number of records to be masked in masking endpoint's log message [#692](https://github.com/ethyca/fidesops/pull/692)
* Datastore Connection Landing Page [#674](https://github.com/ethyca/fidesops/pull/674)
* Added the ability to delete a datastore from the frontend [#683](https://github.com/ethyca/fidesops/pull/683)
Expand Down