Fix/docker16 18 #655
Merged
Fix/docker16 18 #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
mandulaj
force-pushed
the
fix/Docker16_18
branch
from
f09a845
to
d5f10a1
Compare
|
@goldbattle Want to merge this so that the Ubuntu 16 & 18 images are fixed now? Also, let me know if you want some help setting up a GitHub Docker registry for the images with automatic build and pushing. |
|
Any updates on this @goldbattle ? |
|
Many thanks! |
|
It looks like although this has fixed the issue. Sometimes the Docker builds still fail for some reason. I am still looking into why this is the case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
python-catkin-toolsis not authenticated in the older versions of ROS (16 & 18) and must be installed with--allow-unauthenticated.Further more, in Ubuntu 18, one of the ROS packages seems to have an expired GPG key, thus it has to be added manually.