Fixing the context manager for playback objects #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shagren
reviewed
Nov 1, 2022
lpasselin
added a commit
that referenced
this pull request
Feb 3, 2023
* Color image ISO speed for Capture (#176) * Fixing the context manager for playback objects (#181) * Fix: setuptools 67 needs python_requires instead of install_requires (#196) * Added method for getting the extrinsic transformation parameters (#192) * update python versions for github actions (#197) * Update black, flake8 and mypy (#198) --------- Co-authored-by: Johan von Forstner <johan.vonforstner@paradoxcat.com> Co-authored-by: Louis-Philippe Asselin <lpasselin@users.noreply.github.com> Co-authored-by: David Dunn <qenopster@gmail.com> Co-authored-by: David Dunn <dunn@qti.qualcomm.com> Co-authored-by: Ilya Gruzinov <igruzinov@yandex.ru> Co-authored-by: annStein <43335656+annStein@users.noreply.github.com> Co-authored-by: steinimoto <as@motognosis.com> Co-authored-by: Justin <lego.man.123@hotmail.com> Co-authored-by: CMU <ch.chrismuller@pm.me> Co-authored-by: Marcel Egle <97447968+EgleM2022@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #180 : the
__exit__()method should be able to receive 4 arguments.Also fixed a small typo in playback.py (and corresponding tests).