-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create docs subdirectory and Sphinx scaffolding #77
Conversation
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
=======================================
Coverage 91.49% 91.49%
=======================================
Files 6 6
Lines 635 635
=======================================
Hits 581 581
Misses 54 54 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
==========================================
+ Coverage 91.49% 91.52% +0.02%
==========================================
Files 6 6
Lines 635 637 +2
==========================================
+ Hits 581 583 +2
Misses 54 54
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
These .gitignore files in the commit - do we need them?
Should we hook up docs building to the CI job?
Ah, we should probable introduce something like |
May be in upcoming/other commit, we'd probably want to link some of the newly introduced docstrings to this docs infrastructure to see how it works. I suspect you have done that already elsewhere, though. ;-) |
The
Yep, will do! |
I'm having a bit of trouble getting this to work on Py 2.6/3.2/3.3 for the time being-- I'll revert for the time being and create a new issue for this. @etingof does that sound okay?
Right now it's just |
Sure! I am curious what exactly is not working? Sometimes it's necessary to pin on specific versions of Sphinx (or any other dependency) which is still compatible with old Python. On the other hand, those Pythons are seriously obsolete. If the issue is not trivial, may be we could just avoid building docs on them.
I think |
Yep, I think all those Pythons are actually all deprecated! I'll also make an issue for dropping support through Py 3.3. I think this is good to go-- like the linter, I'm just building docs on the most recent Python for the time being. |
They are indeed very old and rarely (?) used. We should probably drop them altogether once we run into a reasonable limitation... My only worry is that there might be people out there still stuck at 2.6... |
Just ran
sphinx-quickstart docs
in the root directory.Only plugin/extension I added was
autodoc
. Let me know if you'd prefer it set up differently.