Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create docs subdirectory and Sphinx scaffolding #77

Merged
merged 7 commits into from
Oct 8, 2019

Conversation

sydneyli
Copy link
Contributor

@sydneyli sydneyli commented Oct 5, 2019

Just ran sphinx-quickstart docs in the root directory.

Only plugin/extension I added was autodoc. Let me know if you'd prefer it set up differently.

@codecov-io
Copy link

codecov-io commented Oct 5, 2019

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files           6        6           
  Lines         635      635           
=======================================
  Hits          581      581           
  Misses         54       54

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b88e1b...ed69e91. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Oct 5, 2019

Codecov Report

Merging #77 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   91.49%   91.52%   +0.02%     
==========================================
  Files           6        6              
  Lines         635      637       +2     
==========================================
+ Hits          581      583       +2     
  Misses         54       54
Impacted Files Coverage Δ
apacheconfig/loader.py 89.16% <0%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b88e1b...6553b27. Read the comment docs.

Copy link
Owner

@etingof etingof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

These .gitignore files in the commit - do we need them?

Should we hook up docs building to the CI job?

@etingof
Copy link
Owner

etingof commented Oct 5, 2019

Ah, we should probable introduce something like test-requirements.txt listing devel/tesing dependencies e.g. Sphinx...

@etingof
Copy link
Owner

etingof commented Oct 5, 2019

May be in upcoming/other commit, we'd probably want to link some of the newly introduced docstrings to this docs infrastructure to see how it works. I suspect you have done that already elsewhere, though. ;-)

@sydneyli
Copy link
Contributor Author

sydneyli commented Oct 7, 2019

These .gitignore files in the commit - do we need them?

The .gitignore files are to make git keep the _static and _templates subdirectories (the sphinx build seems to expect that they exist).

Should we hook up docs building to the CI job?

Yep, will do!

@sydneyli
Copy link
Contributor Author

sydneyli commented Oct 7, 2019

Should we hook up docs building to the CI job?

I'm having a bit of trouble getting this to work on Py 2.6/3.2/3.3 for the time being-- I'll revert for the time being and create a new issue for this. @etingof does that sound okay?

Ah, we should probable introduce something like test-requirements.txt listing devel/tesing dependencies e.g. Sphinx...

Right now it's just test-requirements and requirements-- should we rename test-requirements to dev-requirements and add Sphinx as a dependency there?

@etingof
Copy link
Owner

etingof commented Oct 8, 2019

Should we hook up docs building to the CI job?

I'm having a bit of trouble getting this to work on Py 2.6/3.2/3.3 for the time being-- I'll revert for the time being and create a new issue for this. @etingof does that sound okay?

Sure! I am curious what exactly is not working? Sometimes it's necessary to pin on specific versions of Sphinx (or any other dependency) which is still compatible with old Python.

On the other hand, those Pythons are seriously obsolete. If the issue is not trivial, may be we could just avoid building docs on them.

Ah, we should probable introduce something like test-requirements.txt listing devel/tesing dependencies e.g. Sphinx...

Right now it's just test-requirements and requirements-- should we rename test-requirements to dev-requirements and add Sphinx as a dependency there?

I think requirements.txt is a de-facto (?) standard for listing runtime dependencies. I'd not rename this file into dev-requirements.txt.

@sydneyli
Copy link
Contributor Author

sydneyli commented Oct 8, 2019

On the other hand, those Pythons are seriously obsolete. If the issue is not trivial, may be we could just avoid building docs on them.

Yep, I think all those Pythons are actually all deprecated! I'll also make an issue for dropping support through Py 3.3.

I think this is good to go-- like the linter, I'm just building docs on the most recent Python for the time being.

@etingof etingof merged commit d62be84 into etingof:master Oct 8, 2019
@etingof
Copy link
Owner

etingof commented Oct 8, 2019

Yep, I think all those Pythons are actually all deprecated! I'll also make an issue for dropping support through Py 3.3.

They are indeed very old and rarely (?) used. We should probably drop them altogether once we run into a reasonable limitation... My only worry is that there might be people out there still stuck at 2.6...

@sydneyli sydneyli deleted the sphinx branch October 8, 2019 22:13
@sydneyli sydneyli mentioned this pull request Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants