This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
Fix some bug risks and code quality issues #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Remove unnecessary call to `dict()` and use literals instead for faster access in `simple_salesforce/api.py` and `simple_salesforce/util.py`. Also added .deepsource.toml to configure continuous static analysis with DeepSource.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
dict()and use literals instead forfaster access in
simple_salesforce/api.pyandsimple_salesforce/util.py.This PR also adds
.deepsource.tomlto run static analysis continuously on the repo with DeepSource. Upon enabling DeepSource, static analysis will be run on every PR to detect 550+ types of issues in the changes — including bug risks, anti-patterns, performance issues, security vulnerabilities, etc.To enable DeepSource analysis after merging this PR, please follow these steps:
You can also look at the docs for more details. Do let me know if I can be of any help!
Cheers,
Sanket
Founder, DeepSource