Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): Fix ::selection color on inputs #184

Merged

Conversation

JeanMeche
Copy link
Contributor

Minor fixes about he ::selection color in inputs with errors.

This commit fixes 2 issues:
- LightTheme: the input color was invalid when using css variables
- DarkTheme: both standard colors and css variables where way too light.
@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label May 24, 2023
@MatthieuRiegler-eaton MatthieuRiegler-eaton added needs-review Issues that we would like to revisit/review next-release Work for the next release, not the current one labels May 24, 2023
@JeffGreiner-eaton
Copy link
Collaborator

@JeanMeche can you provide before and after screenshots for this? Also I might not be aware of this change coming in here but inputWarn 50 in blueTheme? is this related to a requested fix/update?

@MatthieuRiegler-eaton
Copy link
Contributor

Hi Jeff, yes these are issues we encountered when using the css variables :

image
Here the text is selected but the color having an error, that's not visible.

And here is the dark one :

image

@JeffGreiner-eaton JeffGreiner-eaton merged commit b100de4 into etn-ccis:release/v9.0.0 May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering needs-review Issues that we would like to revisit/review next-release Work for the next release, not the current one
Development

Successfully merging this pull request may close these issues.

3 participants